lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Nov 2022 23:10:25 +0100 From: Andrew Lunn <andrew@...n.ch> To: Lukasz Majewski <lukma@...x.de> Cc: Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org Subject: Re: [PATCH 6/9] net: dsa: marvell: Provide per device information about max frame size On Thu, Nov 10, 2022 at 04:36:37PM +0100, Lukasz Majewski wrote: > Hi Andrew, > > > On Tue, Nov 08, 2022 at 09:23:27AM +0100, Lukasz Majewski wrote: > > > Different Marvell DSA switches support different size of max frame > > > bytes to be sent. > > > > > > For example mv88e6185 supports max 1632B, which is now in-driver > > > standard value. On the other hand - mv88e6071 supports 2048 bytes. > > > > > > As this value is internal and may be different for each switch IC > > > new entry in struct mv88e6xxx_info has been added to store it. > > > > > > When the 'max_frame_size' is not defined (and hence zeroed by > > > the kvzalloc()) the default of 1632 bytes is used. > > > > I would prefer every entry states the value. > > You mean to add it explicitly (i.e. for each supported switch version) > to the struct mv88e6xxx_ops ? To the info structure. You added it for just your devices and left it to 0 for the rest. Rather than special case 0, always set the value and remove the special case. Maybe even -EINVAL if you find a 0 there. Andrew
Powered by blists - more mailing lists