netdev - Re: [PATCH v2] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba0c84f1-1d99-c0e4-111d-bbd14047ca0b@gmail.com>
Date:   Thu, 10 Nov 2022 09:31:00 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     YueHaibing <yuehaibing@...wei.com>, borisp@...dia.com,
        saeedm@...dia.com, leon@...nel.org, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, lkayal@...dia.com,
        tariqt@...dia.com, markzhang@...dia.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()



On 11/8/2022 9:45 PM, Eric Dumazet wrote:
> On Tue, Nov 8, 2022 at 9:58 AM Tariq Toukan <ttoukan.linux@...il.com> wrote:
>>
>>
>>
>> On 11/8/2022 4:06 PM, YueHaibing wrote:
>>> 'accel_tcp' is allocted by kvzalloc(), which should freed by kvfree().
>>>
>>> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> ---
>>> v2: fix the same issue in mlx5e_accel_fs_tcp_destroy() and a commit log typo
>>> ---
>>>    drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>>> index 285d32d2fd08..d7c020f72401 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
>>> @@ -365,7 +365,7 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs)
>>>        for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++)
>>>                accel_fs_tcp_destroy_table(fs, i);
>>>
>>> -     kfree(accel_tcp);
>>> +     kvfree(accel_tcp);
>>>        mlx5e_fs_set_accel_tcp(fs, NULL);
>>>    }
>>>
>>> @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
>>>    err_destroy_tables:
>>>        while (--i >= 0)
>>>                accel_fs_tcp_destroy_table(fs, i);
>>> -     kfree(accel_tcp);
>>> +     kvfree(accel_tcp);
>>>        mlx5e_fs_set_accel_tcp(fs, NULL);
>>>        return err;
>>>    }
>>
>> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
>>
>> Thanks for your patch.
> 
> Although this structure is 64 bytes... Not sure why kvmalloc() has
> been used for this small chunk.

It's a small chunk indeed. Unnecessary usage of kvmalloc.

Although it's not critical (used only in slowpath), it'd be nice to 
clean it up and directly call kzalloc, instead of aligning the kfree().

YueHaibing, can you please submit a v3 for this?

Regards,
Tariq