netdev - Re: [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: remove an unnecessary restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <900e6177-0a21-e2f5-6c03-81d1dd182c68@linaro.org>
Date:   Fri, 11 Nov 2022 09:26:40 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Alex Elder <elder@...aro.org>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     andersson@...nel.org, konrad.dybcio@...aro.org, agross@...nel.org,
        elder@...nel.org, linux-arm-msm@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: remove an
 unnecessary restriction

On 10/11/2022 20:56, Alex Elder wrote:
> Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name
> property") added a requirement for a "firmware-name" property that
> is more restrictive than necessary.
> 
> If the AP loads GSI firmware, the name of the firmware file to use
> may optionally be provided via a "firmware-name" property.  If the
> *modem* loads GSI firmware, "firmware-name" doesn't need to be
> supplied--but it's harmless to do so (it will simply be ignored).
> 
> Remove the unnecessary restriction, and allow "firware-name" to be
> supplied even if it's not needed.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ----------


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof