netdev - Re: [RFC] option to use proper skew timings for Micrel KSZ9021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 10:34:48 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC] option to use proper skew timings for Micrel KSZ9021

On 09/11/2022 17:27, Andrew Lunn wrote:
>> I would like to add an optional boolean property to indicate that the skew
>> timing properties are to be interpreted as "proper" skew timings (in 120ps
>> steps) rather than fake skew timings.  When this property is true, the
>> driver can divide the specified skew timing values by 120 instead of 200.
>> The advantage of this is that the same skew timing property values can be
>> used in the device node and will apply to both KSZ9021 and KSZ9031 as long
>> as the values are in range for both chips.
> 
> Hi Ian
> 
> I don't see why this is an advantage. Yes, it is all messed up, but it
> is a well defined and documented mess. All this boolean will do is
> make it a more complex mess, leading it more errors with the wrong
> value set.

Hi Andrew,

I can think of a couple of use cases.  For example:

1. Forward planning to replace KSZ9021 with KSZ9031 in a future hardware 
iteration.  As long as the device tree and kernel driver (and possibly 
the bootloader if it uses the same device tree blob as the kernel 
internally) are upgraded at the same time, software upgrades of existing 
hardware with KSZ9021 will continue to work correctly.  Upgraded 
hardware with KSZ9031 will work properly with the updated software.

2. Due to KSZ9031 chip shortages, it may be useful to replace KSZ9031 
with KSZ9021 for a few manufacturing runs.  This can be done as long as 
the device tree and driver are updated to know about the new property in 
time for those manufacturing runs.

In both cases, the skew timings chosen would need to apply to both 
KSZ9021 and KSZ9031.

(At the time of writing, KSZ9031RNX chips are very difficult to get hold 
of except at exorbitant prices from scalpers (~US$200 per chip!), but 
the older generation KSZ9021RN chips are much easier to get hold of 
(~US$5 per chip).)

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-