lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221111082551.7e71fbf4@kernel.org> Date: Fri, 11 Nov 2022 08:25:51 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Yury Norov <yury.norov@...il.com> Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Barry Song <baohua@...nel.org>, Ben Segall <bsegall@...gle.com>, Daniel Bristot de Oliveira <bristot@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, Gal Pressman <gal@...dia.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heiko Carstens <hca@...ux.ibm.com>, Ingo Molnar <mingo@...hat.com>, Jason Gunthorpe <jgg@...dia.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Juri Lelli <juri.lelli@...hat.com>, Leon Romanovsky <leonro@...dia.com>, Mel Gorman <mgorman@...e.de>, Peter Zijlstra <peterz@...radead.org>, Rasmus Villemoes <linux@...musvillemoes.dk>, Saeed Mahameed <saeedm@...dia.com>, Steven Rostedt <rostedt@...dmis.org>, Tariq Toukan <tariqt@...dia.com>, Tariq Toukan <ttoukan.linux@...il.com>, Tony Luck <tony.luck@...el.com>, Valentin Schneider <vschneid@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, linux-crypto@...r.kernel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org Subject: Re: [PATCH 0/4] cpumask: improve on cpumask_local_spread() locality On Thu, 10 Nov 2022 20:00:23 -0800 Yury Norov wrote: > cpumask_local_spread() currently checks local node for presence of i'th > CPU, and then if it finds nothing makes a flat search among all non-local > CPUs. We can do it better by checking CPUs per NUMA hops. Nice. > This series is inspired by Valentin Schneider's "net/mlx5e: Improve remote > NUMA preferences used for the IRQ affinity hints" > > https://patchwork.kernel.org/project/netdevbpf/patch/20220728191203.4055-3-tariqt@nvidia.com/ > > According to Valentin's measurements, for mlx5e: > > Bottleneck in RX side is released, reached linerate (~1.8x speedup). > ~30% less cpu util on TX. > > This patch makes cpumask_local_spread() traversing CPUs based on NUMA > distance, just as well, and I expect comparabale improvement for its > users, as in Valentin's case. > > I tested it on my VM with the following NUMA configuration: nit: the authorship is a bit more complicated, it'd be good to mention Tariq. Both for the code and attribution of the testing / measurements.
Powered by blists - more mailing lists