netdev - Re: [PATCH RESEND v2] wifi: ath10k: Fix return value in ath10k_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a484effb-9da3-9888-c11d-2d36ece7a342@quicinc.com>
Date:   Fri, 11 Nov 2022 11:59:41 -0800
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>, <kvalo@...nel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <rmani@....qualcomm.com>
CC:     <ath10k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND v2] wifi: ath10k: Fix return value in
 ath10k_pci_init()

On 11/9/2022 10:19 PM, Xiu Jianfeng wrote:
> This driver is attempting to register to support two different buses.
> if either of these is successful then ath10k_pci_init() should return 0
> so that hardware attached to the successful bus can be probed and
> supported. only if both of these are unsuccessful should ath10k_pci_init()
> return an errno.
> 
> Fixes: 0b523ced9a3c ("ath10k: add basic skeleton to support ahb")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>