netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: Allow hwstamping on the master port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221111214127.pzek6eonetzatc4a@skbuf>
Date:   Fri, 11 Nov 2022 23:41:27 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     kuba@...nel.org, andrew@...n.ch, netdev@...r.kernel.org,
        Steffen Bätz <steffen@...osonix.de>,
        Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Allow hwstamping on the
 master port

On Fri, Nov 11, 2022 at 08:13:56AM -0300, Fabio Estevam wrote:
> Hi Vladimir,
> 
> On Thu, Nov 10, 2022 at 9:53 AM Vladimir Oltean <olteanv@...il.com> wrote:
> 
> > NACK.
> >
> > Please extend dsa_master_ioctl() to "see through" the dp->ds->ops->port_hwtstamp_get()
> > pointer, similar to what dsa_port_can_configure_learning() does. Create
> > a fake struct ifreq, call port_hwtstamp_get(), see if it returned
> > -EOPNOTSUPP, and wrap that into a dsa_port_supports_hwtstamp() function,
> > and call that instead of the current simplistic checks for the function
> > pointers.
> 
> I tried to implement what you suggested in the attached patch, but I
> am not sure it is correct.
> 
> If it doesn't work, please cook a patch so we can try it.

Yeah, this is not what I meant. I posted a patch illustrating what I
meant here:
https://patchwork.kernel.org/project/netdevbpf/patch/20221111211020.543540-1-vladimir.oltean@nxp.com/