[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 10 Nov 2022 16:25:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Wei Yongjun <weiyongjun@...weicloud.com>
Cc: Loic Poulain <loic.poulain@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: mhi: Fix memory leak in mhi_net_dellink()
On Wed, 9 Nov 2022 10:09:15 +0000 Wei Yongjun wrote:
> MHI driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
>
> This patch calls free_netdev() to fix it since netdev_priv
> is used after unregister.
>
> Fixes: 7ffa7542eca6 ("net: mhi: Remove MBIM protocol")
I don't see how the bug is introduced by this commit.
Please find the correct fixes tag or add an explanation of how the bug
got added.
Powered by blists - more mailing lists