netdev - Re: [PATCH net-next 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 14:46:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniele Palmas <dnlplm@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>,
        Sean Tranchetti <quic_stranche@...cinc.com>,
        Jonathan Corbet <corbet@....net>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Daniele Palmas <dnlplm@...il.com>
Subject: Re: [PATCH net-next 3/3] net: qualcomm: rmnet: add ethtool support
 for configuring tx aggregation

Hi Daniele,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniele-Palmas/add-tx-packets-aggregation-to-ethtool-and-rmnet/20221110-021152
patch link:    https://lore.kernel.org/r/20221109180249.4721-4-dnlplm%40gmail.com
patch subject: [PATCH net-next 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation
config: arm-randconfig-c033-20221110
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1d616d4cfe80553017ff177ae01d4bbfcaf48213
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniele-Palmas/add-tx-packets-aggregation-to-ethtool-and-rmnet/20221110-021152
        git checkout 1d616d4cfe80553017ff177ae01d4bbfcaf48213
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.o: in function `rmnet_get_coalesce':
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:226: undefined reference to `__aeabi_uldivmod'


vim +226 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c

   212	
   213	static int rmnet_get_coalesce(struct net_device *dev,
   214				      struct ethtool_coalesce *coal,
   215				      struct kernel_ethtool_coalesce *kernel_coal,
   216				      struct netlink_ext_ack *extack)
   217	{
   218		struct rmnet_priv *priv = netdev_priv(dev);
   219		struct rmnet_port *port;
   220	
   221		port = rmnet_get_port_rtnl(priv->real_dev);
   222	
   223		memset(kernel_coal, 0, sizeof(*kernel_coal));
   224		kernel_coal->tx_max_aggr_size = port->egress_agg_params.agg_size;
   225		kernel_coal->tx_max_aggr_frames = port->egress_agg_params.agg_count;
 > 226		kernel_coal->tx_usecs_aggr_time = port->egress_agg_params.agg_time_nsec / NSEC_PER_USEC;
   227	
   228		return 0;
   229	}
   230	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (177559 bytes)