netdev - Re: [PATCH v2] tcp: Add listening address to SYN flood message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAvyFNhkn2Zv16RMWGCtQh4SpjJX56q8gyEL3Mz6Ru+Ef=SJfA@mail.gmail.com>
Date:   Sat, 12 Nov 2022 10:59:52 +1100
From:   Jamie Bainbridge <jamie.bainbridge@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tcp: Add listening address to SYN flood message

On Sat, 12 Nov 2022 at 04:20, Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Fri, 11 Nov 2022 14:59:32 +1100
> Jamie Bainbridge <jamie.bainbridge@...il.com> wrote:
>
> > +         xchg(&queue->synflood_warned, 1) == 0) {
> > +             if (IS_ENABLED(CONFIG_IPV6) && sk->sk_family == AF_INET6) {
> > +                     net_info_ratelimited("%s: Possible SYN flooding on port %pI6c.%u. %s.\n",
> > +                                     proto, &sk->sk_v6_rcv_saddr,
> > +                                     sk->sk_num, msg);
> > +             } else {
> > +                     net_info_ratelimited("%s: Possible SYN flooding on port %pI4.%u. %s.\n",
> > +                                     proto, &sk->sk_rcv_saddr,
> > +                                     sk->sk_num, msg);
>
> Minor nit, the standard format for printing addresses would be to use colon seperator before port
>
>                 if (IS_ENABLED(CONFIG_IPV6) && sk->sk_family == AF_INET6) {
>                         net_info_ratelimited("%s: Possible SYN flooding on [%pI6c]:%u. %s.\n",
>                                         proto, &sk->sk_v6_rcv_saddr, sk->sk_num, msg);
>                 } else {
>                         net_info_ratelimited("%s: Possible SYN flooding on %pI4:%u. %s.\n",
>                                         proto, &sk->sk_rcv_saddr, sk->sk_num, msg);

I considered this too, though Eric suggested "IP.port" to match tcpdump.

Please let me know which advice to follow?

Jamie