netdev - Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary exposure of stats structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211121820.gjss1F2d-lkp@intel.com>
Date:   Sat, 12 Nov 2022 18:34:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Colin Foster <colin.foster@...advantage.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary
 exposure of stats structures

Hi Colin,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Colin-Foster/cleanup-ocelot_stats-exposure/20221112-045112
patch link:    https://lore.kernel.org/r/20221111204924.1442282-3-colin.foster%40in-advantage.com
patch subject: [PATCH v1 net-next 2/2] net: mscc: ocelot: remove unnecessary exposure of stats structures
config: riscv-randconfig-r006-20221111
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/a3776d04a54157529fe520cd9667c8dc1104ef74
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Colin-Foster/cleanup-ocelot_stats-exposure/20221112-045112
        git checkout a3776d04a54157529fe520cd9667c8dc1104ef74
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/ethernet/mscc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:103:60: error: use of undeclared identifier 'OCELOT_NUM_STATS'; did you mean 'OCELOT_ES0_TAG'?
   static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = {
                                                              ^~~~~~~~~~~~~~~~
                                                              OCELOT_ES0_TAG
   include/soc/mscc/ocelot_vcap.h:605:2: note: 'OCELOT_ES0_TAG' declared here
           OCELOT_ES0_TAG,
           ^
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:103:59: error: array has incomplete element type 'const struct ocelot_stat_layout'
   static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = {
                                                             ^
   drivers/net/ethernet/mscc/ocelot_vsc7514.c:103:21: note: forward declaration of 'struct ocelot_stat_layout'
   static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = {
                       ^
>> drivers/net/ethernet/mscc/ocelot_vsc7514.c:104:2: error: use of undeclared identifier 'OCELOT_COMMON_STATS'
           OCELOT_COMMON_STATS,
           ^
   3 errors generated.


vim +103 drivers/net/ethernet/mscc/ocelot_vsc7514.c

d9feb904997333 Vladimir Oltean 2020-06-20  102  
9190460084ddd0 Vladimir Oltean 2022-08-16 @103  static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = {
4d1d157fb6a49f Vladimir Oltean 2022-09-08 @104  	OCELOT_COMMON_STATS,
d9feb904997333 Vladimir Oltean 2020-06-20  105  };
d9feb904997333 Vladimir Oltean 2020-06-20  106  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (198750 bytes)