netdev - Re: [PATCH linux-next] net: af_key: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221114064332.GL665047@gauss3.secunet.de>
Date:   Mon, 14 Nov 2022 07:43:32 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <zhang.songyi@....com.cn>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <jiang.xuexin@....com.cn>, <xue.zhihong@....com.cn>
Subject: Re: [PATCH linux-next] net: af_key: remove redundant ret variable

On Wed, Nov 02, 2022 at 09:46:33PM +0800, zhang.songyi@....com.cn wrote:
> >From a09ddf4bd144610fd17bdbf07f0c27700d805e6f Mon Sep 17 00:00:00 2001
> From: zhang songyi <zhang.songyi@....com.cn>
> Date: Wed, 2 Nov 2022 21:05:39 +0800
> Subject: [PATCH linux-next] net: af_key: remove redundant ret variable
> 
> Return value from pfkey_net_init() directly instead of taking this in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>

pfkey is deprecated and should not be used anymore.
Please do changes to pfkey just if there is a real
bug to fix.

Thanks!