netdev - Re: [PATCH v2 net-next 3/4] net: mscc: ocelot: drop workaround for forcing RX flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3J2lHuIlzRCyPTq@shell.armlinux.org.uk>
Date:   Mon, 14 Nov 2022 17:10:44 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sean Anderson <sean.anderson@...o.com>,
        Colin Foster <colin.foster@...advantage.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next 3/4] net: mscc: ocelot: drop workaround for
 forcing RX flow control

On Mon, Nov 14, 2022 at 07:07:29PM +0200, Vladimir Oltean wrote:
> As phylink gained generic support for PHYs with rate matching via PAUSE
> frames, the phylink_mac_link_up() method will be called with the maximum
> speed and with rx_pause=true if rate matching is in use. This means that
> setups with 2500base-x as the SERDES protocol between the MAC/PCS and
> the PHY now work with no need for the driver to do anything special.
> 
> Tested with fsl-ls1028a-qds-7777.dts.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

LGTM.

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!