netdev - Re: [PATCH] net: ionic: Fix error handling in ionic_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 10:29:56 -0800
From:   Shannon Nelson <shnelson@....com>
To:     Yuan Can <yuancan@...wei.com>, snelson@...sando.io,
        drivers@...sando.io, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, brett@...sando.io,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: ionic: Fix error handling in ionic_init_module()

On 11/13/22 1:29 AM, Yuan Can wrote:
> A problem about ionic create debugfs failed is triggered with the
> following log given:
> 
>   [  415.799514] debugfs: Directory 'ionic' with parent '/' already present!
> 
> The reason is that ionic_init_module() returns ionic_bus_register_driver()
> directly without checking its return value, if ionic_bus_register_driver()
> failed, it returns without destroy the newly created debugfs, resulting
> the debugfs of ionic can never be created later.
> 
>   ionic_init_module()
>     ionic_debugfs_create() # create debugfs directory
>     ionic_bus_register_driver()
>       pci_register_driver()
>         driver_register()
>           bus_add_driver()
>             priv = kzalloc(...) # OOM happened
>     # return without destroy debugfs directory
> 
> Fix by removing debugfs when ionic_bus_register_driver() returns error.
> 
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Yuan Can <yuancan@...wei.com>

Acked-by: Shannon Nelson <snelson@...sando.io>


> ---
>   drivers/net/ethernet/pensando/ionic/ionic_main.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> index 56f93b030551..5456c2b15d9b 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> @@ -687,8 +687,14 @@ int ionic_port_reset(struct ionic *ionic)
> 
>   static int __init ionic_init_module(void)
>   {
> +       int ret;
> +
>          ionic_debugfs_create();
> -       return ionic_bus_register_driver();
> +       ret = ionic_bus_register_driver();
> +       if (ret)
> +               ionic_debugfs_destroy();
> +
> +       return ret;
>   }
> 
>   static void __exit ionic_cleanup_module(void)
> --
> 2.17.1
>