netdev - Re: [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3KiovqzjhfeyR80@lunn.ch>
Date:   Mon, 14 Nov 2022 21:18:42 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexander Lobakin <alexandr.lobakin@...el.com>
Cc:     Mengyuan Lou <mengyuanlou@...-swift.com>, netdev@...r.kernel.org,
        jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module

On Mon, Nov 14, 2022 at 04:34:38PM +0100, Alexander Lobakin wrote:
> From: Mengyuan Lou <mengyuanlou@...-swift.com>
> Date: Tue,  8 Nov 2022 19:19:03 +0800
> 
> > From: Jiawen Wu <jiawenwu@...stnetic.com>
> > 
> > Add to get media type and physical layer module, support I2C access.
> > 
> > Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> > ---
> 
> [...]
> 
> > @@ -277,11 +647,30 @@ int txgbe_reset_hw(struct txgbe_hw *hw)
> >  	struct wx_hw *wxhw = &hw->wxhw;
> >  	int status;
> >  
> > +	u32 sr_pcs_ctl, sr_pma_mmd_ctl1, sr_an_mmd_ctl, sr_an_mmd_adv_reg2;
> > +	u32 vr_xs_or_pcs_mmd_digi_ctl1, curr_vr_xs_or_pcs_mmd_digi_ctl1;
> > +	u32 curr_sr_an_mmd_ctl, curr_sr_an_mmd_adv_reg2;
> > +	u32 curr_sr_pcs_ctl, curr_sr_pma_mmd_ctl1;
> 
> Please merge this with the first declaration block, there must be
> only one.
> Also, are you sure you need all this simultaneously? Maybe reuse
> some of them?

I would not actually spend too much time reviewing this code. It needs
restructuring into a pcs driver, maybe in driver/net/pcs. And some of
it might get turning into generic PHY driver.

Very likely, this whole driver will get re-written as it is merged.

	Andrew