netdev - Re: [PATCH net-next v2 0/2] gve: Handle alternate miss-completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 12:32:43 -0800
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jeroen de Borst <jeroendb@...gle.com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 0/2] gve: Handle alternate miss-completions

On 11/11/2022 8:35 AM, Jeroen de Borst wrote:
> Some versions of the virtual NIC present miss-completions in
> an alternative way. This patchset lets the diver handle these
nit:                                         ^^^^^
                                              driver

nit: use imperative voice. replace "This patchset lets" with "Let"

> alternate completions and announce this capability to the device.
> 
> Changes in v2:
> - Changed the subject to include 'gve:'
> 
> Jeroen de Borst (2):
>    gve: Adding a new AdminQ command to verify driver
>    gve: Handle alternate miss completions
> 
>   drivers/net/ethernet/google/gve/gve.h         |  1 +
>   drivers/net/ethernet/google/gve/gve_adminq.c  | 19 +++++++
>   drivers/net/ethernet/google/gve/gve_adminq.h  | 51 ++++++++++++++++++
>   .../net/ethernet/google/gve/gve_desc_dqo.h    |  5 ++
>   drivers/net/ethernet/google/gve/gve_main.c    | 52 +++++++++++++++++++
>   drivers/net/ethernet/google/gve/gve_tx_dqo.c  | 18 ++++---
>   6 files changed, 140 insertions(+), 6 deletions(-)
> 

I looked over this series for things that didn't make sense and I didn't 
find any, so, esp if you fix the cover letter stuff above.

For the series:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>