netdev - RE: [PATCH v2] can: etas_es58x: free netdev when register_candev() failed in es58x_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR10MB232575E04F886D1B9341DD21C7059@AM6PR10MB2325.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 14 Nov 2022 08:32:52 +0000
From:   "Arunachalam Santhanam (MS/ETA-ETAS)" 
        <Arunachalam.Santhanam@...bosch.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        "EXTERNAL Kleine-Budde Marc (Pengutronix, XC-CT/ECP2)" 
        <mkl@...gutronix.de>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] can: etas_es58x: free netdev when register_candev()
 failed in es58x_init_netdev()

Hi Zhang,

Thank you for the update and patch.

-----Original Message-----
From: Zhang Changzhong <zhangchangzhong@...wei.com> 
Sent: 14 November 2022 13:45
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>; Wolfgang Grandegger <wg@...ndegger.com>; EXTERNAL Kleine-Budde Marc (Pengutronix, XC-CT/ECP2) <mkl@...gutronix.de>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Arunachalam Santhanam (MS/ETA-ETAS) <arunachalam.santhanam@...bosch.com>
Cc: Zhang Changzhong <zhangchangzhong@...wei.com>; linux-can@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH v2] can: etas_es58x: free netdev when register_candev() failed in es58x_init_netdev()

In case of register_candev() fails, clear es58x_dev->netdev[channel_idx] and add free_candev(). Otherwise es58x_free_netdevs() will unregister the netdev that has never been registered.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Signed-off-by: Zhang Changzhong <mailto:zhangchangzhong@...wei.com>
---
v1 -> v2: change to the correct 'Fixes' tag according to Vincent Mailhol

Acked-by: <arunachalam.santhanam@...bosch.com>

 drivers/net/can/usb/etas_es58x/es58x_core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
index 25f863b..ddb7c57 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
@@ -2091,8 +2091,11 @@ static int es58x_init_netdev(struct es58x_device *es58x_dev, int channel_idx)
 	netdev->dev_port = channel_idx;
 
 	ret = register_candev(netdev);
-	if (ret)
+	if (ret) {
+		es58x_dev->netdev[channel_idx] = NULL;
+		free_candev(netdev);
 		return ret;
+	}
 
 	netdev_queue_set_dql_min_limit(netdev_get_tx_queue(netdev, 0),
 				       es58x_dev->param->dql_min_limit);
--
2.9.5