netdev - Re: [PATCH net 2/3] net: hns3: fix return value check bug of rx copybreak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <750a820f-b01a-59f5-a6c9-26e0d793dafe@huawei.com>
Date:   Mon, 14 Nov 2022 16:47:26 +0800
From:   Hao Lan <lanhao@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     <lipeng321@...wei.com>, <shenjian15@...wei.com>,
        <linyunsheng@...wei.com>, <liuyonglong@...wei.com>,
        <chenhao418@...wei.com>, <wangjie125@...wei.com>,
        <huangguangbin2@...wei.com>, <yisen.zhuang@...wei.com>,
        <salil.mehta@...wei.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <xiaojiantao1@...artners.com>
Subject: Re: [PATCH net 2/3] net: hns3: fix return value check bug of rx
 copybreak

Thank you, I will send patch V2.

On 2022/11/14 15:39, Leon Romanovsky wrote:
> On Sat, Nov 12, 2022 at 04:21:17PM +0800, Hao Lan wrote:
>> From: Jie Wang <wangjie125@...wei.com>
>>
>> The refactoring of rx copybreak modifies the original return logic, which
>> will make this feature unavailable. So this patch fixes the return logic of
>> rx copybreak.
>>
>> Fixes: e74a726da2c4 ("net: hns3: refactor hns3_nic_reuse_page()")
>> Fixes: 99f6b5fb5f63 ("net: hns3: use bounce buffer when rx page can not be reused")
>>
>> Signed-off-by: Jie Wang <wangjie125@...wei.com>
> 
> Please delete blank line between Fixes and SOBs, in all three patches.
> 
> Thanks
> .
>