netdev - Re: [patch 07/10] net: nfp: Remove linux/msi.h includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3IcoZkLMTeJPvyt@corigine.com>
Date:   Mon, 14 Nov 2022 11:46:57 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, Marc Zyngier <maz@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, oss-drivers@...igine.com,
        netdev@...r.kernel.org
Subject: Re: [patch 07/10] net: nfp: Remove linux/msi.h includes

On Sun, Nov 13, 2022 at 09:34:05PM +0100, Thomas Gleixner wrote:
> [Some people who received this message don't often get email from tglx@...utronix.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Nothing in these files needs anything from linux/msi.h
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Simon Horman <simon.horman@...igine.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: oss-drivers@...igine.com
> Cc: netdev@...r.kernel.org

Acked-by: Simon Horman <simon.horman@...igine.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_main.h       |    1 -
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c |    1 -
>  drivers/net/ethernet/netronome/nfp/nfp_net_main.c   |    1 -
>  3 files changed, 3 deletions(-)
> 
> --- a/drivers/net/ethernet/netronome/nfp/nfp_main.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_main.h
> @@ -12,7 +12,6 @@
>  #include <linux/ethtool.h>
>  #include <linux/list.h>
>  #include <linux/types.h>
> -#include <linux/msi.h>
>  #include <linux/pci.h>
>  #include <linux/workqueue.h>
>  #include <net/devlink.h>
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -27,7 +27,6 @@
>  #include <linux/page_ref.h>
>  #include <linux/pci.h>
>  #include <linux/pci_regs.h>
> -#include <linux/msi.h>
>  #include <linux/ethtool.h>
>  #include <linux/log2.h>
>  #include <linux/if_vlan.h>
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> @@ -16,7 +16,6 @@
>  #include <linux/lockdep.h>
>  #include <linux/pci.h>
>  #include <linux/pci_regs.h>
> -#include <linux/msi.h>
>  #include <linux/random.h>
>  #include <linux/rtnetlink.h>
> 
>