netdev - Re: [PATCH (repost) net-next] sched: add extack for tfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmiGBb1B=mYyG1FEvX7RRh+UvTFwguuEy9UwBPg2Jd0KA@mail.gmail.com>
Date:   Tue, 15 Nov 2022 08:13:15 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

On Tue, Nov 15, 2022 at 7:44 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Mon, Nov 14, 2022 at 08:51:43PM -0800, Jakub Kicinski wrote:
> > > So maybe I should stop on here?
> >
> > It's a bit of a catch 22 - I don't mind the TCA_NTF_WARN_MSG itself
> > but I would prefer for the extack via notification to spread to other
> > notifications.
>
> Not sure if we could find a way to pass the GROUP ID to netlink_ack(),
> and use nlmsg_notify() instead of nlmsg_unicast() in it. Then the tc monitor
> could handle the NLMSG_ERROR directly.
>

That's what I meant. Do you have time to try this? Otherwise i will make time.
Your patch is still very specific to cls. If you only look at h/w
offload, actions can also
be added independently and fail independently as well. But in general this would
be useful for all notifications.

cheers,
jamal