netdev - Re: [PATCH net-next] net: phy: mscc: macsec: do not copy encryption keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <166852429383.51101.3677122083527960854@kwain>
Date:   Tue, 15 Nov 2022 15:58:13 +0100
From:   Antoine Tenart <atenart@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org
Cc:     sd@...asysnail.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: mscc: macsec: do not copy encryption keys

Hi,

Quoting Paolo Abeni (2022-11-15 15:38:06)
> On Mon, 2022-11-14 at 10:20 +0100, Antoine Tenart wrote:
> > Instead of calling memzero_explicit on the key when freeing a flow,
> > let's simply not copy the key in the first place as it's only used when
> > a new flow is set up.
> > 
> > Signed-off-by: Antoine Tenart <atenart@...nel.org>
> > ---
> > 
> > Following
> > https://lore.kernel.org/all/20221108153459.811293-1-atenart@kernel.org/T/
> > refactor the MSCC PHY driver not to make a copy the encryption keys.
> 
> The patch LGTM, but would you mind including into the commit message a
> reference to the -net commit, so that the dependency is there to
> simplify eventual backports?

Sure, will do in a v2.

Thanks!
Antoine