netdev - Re: [PATCH net-next 1/3] ethtool: add tx aggregation parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221115082147.1456a39b@kernel.org>
Date:   Tue, 15 Nov 2022 08:21:47 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Gal Pressman <gal@...dia.com>
Cc:     Daniele Palmas <dnlplm@...il.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>,
        Sean Tranchetti <quic_stranche@...cinc.com>,
        Jonathan Corbet <corbet@....net>,
        Bjørn Mork <bjorn@...k.no>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] ethtool: add tx aggregation parameters

On Tue, 15 Nov 2022 12:59:47 +0200 Gal Pressman wrote:
> Thanks for the explanation.
> How would this apply to a pci netdev driver?

I don't think it would. I've only seen it on USB devices.
We should add a note to this effect to the documentation.
Perhaps other funny buses may use it but PCIe remains efficient 
for packet sizes below standard MTUs so unlikely we'd need this
sort of aggregation.