netdev - [PATCH iproute2-next] bridge: Remove unused function argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 16:07:15 -0500
From:   Benjamin Poirier <bpoirier@...dia.com>
To:     David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
        Roopa Prabhu <roopa@...dia.com>
Subject: [PATCH iproute2-next] bridge: Remove unused function argument

print_vnifilter_rtm() was probably modeled on print_vlan_rtm() but the
'monitor' argument is unused in the vnifilter case.

Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>
Reviewed-by: Ido Schimmel <idosch@...dia.com>
---
 bridge/br_common.h | 2 +-
 bridge/monitor.c   | 2 +-
 bridge/vni.c       | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bridge/br_common.h b/bridge/br_common.h
index da677df8..1bdee658 100644
--- a/bridge/br_common.h
+++ b/bridge/br_common.h
@@ -14,7 +14,7 @@ void print_stp_state(__u8 state);
 int parse_stp_state(const char *arg);
 int print_vlan_rtm(struct nlmsghdr *n, void *arg, bool monitor,
 		   bool global_only);
-int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor);
+int print_vnifilter_rtm(struct nlmsghdr *n, void *arg);
 void br_print_router_port_stats(struct rtattr *pattr);
 void print_headers(FILE *fp, const char *label);
 
diff --git a/bridge/monitor.c b/bridge/monitor.c
index e321516a..d82f45cc 100644
--- a/bridge/monitor.c
+++ b/bridge/monitor.c
@@ -63,7 +63,7 @@ static int accept_msg(struct rtnl_ctrl_data *ctrl,
 
 	case RTM_NEWTUNNEL:
 	case RTM_DELTUNNEL:
-		return print_vnifilter_rtm(n, arg, true);
+		return print_vnifilter_rtm(n, arg);
 
 	default:
 		return 0;
diff --git a/bridge/vni.c b/bridge/vni.c
index e776797a..940f251c 100644
--- a/bridge/vni.c
+++ b/bridge/vni.c
@@ -303,7 +303,7 @@ static void print_vni(struct rtattr *t, int ifindex)
 	print_string(PRINT_FP, NULL, "%s", _SL_);
 }
 
-int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor)
+int print_vnifilter_rtm(struct nlmsghdr *n, void *arg)
 {
 	struct tunnel_msg *tmsg = NLMSG_DATA(n);
 	int len = n->nlmsg_len;
@@ -364,7 +364,7 @@ int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor)
 
 static int print_vnifilter_rtm_filter(struct nlmsghdr *n, void *arg)
 {
-	return print_vnifilter_rtm(n, arg, false);
+	return print_vnifilter_rtm(n, arg);
 }
 
 static int vni_show(int argc, char **argv)
-- 
2.37.2