netdev - Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 21:18:04 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>,
        Ido Schimmel <idosch@...sch.org>
Cc:     "Hans J. Schultz" <netdev@...io-technology.com>,
        davem@...emloft.net, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support

On Mon, 14 Nov 2022 18:57:04 -0800 Jakub Kicinski wrote:
> On Sat, 12 Nov 2022 21:37:46 +0100 Hans J. Schultz wrote:
> > This patchset adds MAB [1] offload support in mv88e6xxx.
> > 
> > Patch #1: Fix a problem when reading the FID needed to get the VID.
> > 
> > Patch #2: The MAB implementation for mv88e6xxx.
> > 
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=a35ec8e38cdd1766f29924ca391a01de20163931  
> 
> Vladimir, Ido, ack?

Ah, either way a v9 will be needed:

drivers/net/dsa/mv88e6xxx/switchdev.c:33:5: warning: no previous prototype for function 'mv88e6xxx_handle_violation' [-Wmissing-prototypes]
int mv88e6xxx_handle_violation(struct mv88e6xxx_chip *chip, int port,
    ^
drivers/net/dsa/mv88e6xxx/switchdev.c:33:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int mv88e6xxx_handle_violation(struct mv88e6xxx_chip *chip, int port,
^