netdev - Re: [PATCH] net/mlx4: Check retval of mlx4_bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221115203205.0c55ceee@kernel.org>
Date:   Tue, 15 Nov 2022 20:32:05 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Peter Kosyh <pkosyh@...dex.ru>
Cc:     Tariq Toukan <tariqt@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] net/mlx4: Check retval of mlx4_bitmap_init

On Tue, 15 Nov 2022 12:53:56 +0300 Peter Kosyh wrote:
> If mlx4_bitmap_init fails, mlx4_bitmap_alloc_range will dereference
> the NULL pointer (bitmap->table).
> 
> Make sure, that mlx4_bitmap_alloc_range called in no error case.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Peter Kosyh <pkosyh@...dex.ru>

Please repost with an appropriate Fixes: tag and [PATCH net] in the
subject. Please keep Tariq's review tag.