netdev - Re: [PATCH net-next] mlxsw: update adjfine to use adjust_by_scaled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221116122023.170981ff@kernel.org>
Date:   Wed, 16 Nov 2022 12:20:23 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...dia.com>,
        Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Amit Cohen <amcohen@...dia.com>,
        Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH net-next] mlxsw: update adjfine to use
 adjust_by_scaled_ppm

On Wed, 16 Nov 2022 10:01:18 +0200 Ido Schimmel wrote:
> On Mon, Nov 14, 2022 at 01:37:01PM -0800, Jacob Keller wrote:
> > The mlxsw adjfine implementation in the spectrum_ptp.c file converts
> > scaled_ppm into ppb before updating a cyclecounter multiplier using the
> > standard "base * ppb / 1billion" calculation.
> > 
> > This can be re-written to use adjust_by_scaled_ppm, directly using the
> > scaled parts per million and reducing the amount of code required to
> > express this calculation.
> > 
> > We still calculate the parts per billion for passing into
> > mlxsw_sp_ptp_phc_adjfreq because this function requires the input to be in
> > parts per billion.
> > 
> > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>  
> 
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Tested-by: Ido Schimmel <idosch@...dia.com>

FTR this patch got marked as 'not applicable' in pw but I'm not sure
why, so applying...