netdev - Re: [PATCH net-next 1/5] openvswitch: delete the unncessary skb_pull_rcsum call in ovs_ct_nat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7to7t64o1j.fsf@redhat.com>
Date:   Wed, 16 Nov 2022 15:55:36 -0500
From:   Aaron Conole <aconole@...hat.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, dev@...nvswitch.org,
        davem@...emloft.net, kuba@...nel.org,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Pravin B Shelar <pshelar@....org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>
Subject: Re: [PATCH net-next 1/5] openvswitch: delete the unncessary
 skb_pull_rcsum call in ovs_ct_nat_execute

Xin Long <lucien.xin@...il.com> writes:

> The calls to ovs_ct_nat_execute() are as below:
>
>   ovs_ct_execute()
>     ovs_ct_lookup()
>       __ovs_ct_lookup()
>         ovs_ct_nat()
>           ovs_ct_nat_execute()
>     ovs_ct_commit()
>       __ovs_ct_lookup()
>         ovs_ct_nat()
>           ovs_ct_nat_execute()
>
> and since skb_pull_rcsum() and skb_push_rcsum() are already
> called in ovs_ct_execute(), there's no need to do it again
> in ovs_ct_nat_execute().
>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---

LGTM

Acked-by: Aaron Conole <aconole@...hat.com>