netdev - Re: [PATCH net] net: liquidio: simplify if expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3VruaIDzVH7jqPQ@x130.lan>
Date:   Wed, 16 Nov 2022 15:01:13 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leonro@...dia.com>,
        Derek Chickles <dchickles@...vell.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Felix Manlunas <fmanlunas@...vell.com>,
        kernel test robot <lkp@...el.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Satanand Burla <sburla@...vell.com>,
        Zhengchao Shao <shaozhengchao@...wei.com>
Subject: Re: [PATCH net] net: liquidio: simplify if expression

On 15 Nov 19:34, Leon Romanovsky wrote:
>From: Leon Romanovsky <leonro@...dia.com>
>
>Fix the warning reported by kbuild:
>
>cocci warnings: (new ones prefixed by >>)
>>> drivers/net/ethernet/cavium/liquidio/lio_main.c:1797:54-56: WARNING !A || A && B is equivalent to !A || B
>   drivers/net/ethernet/cavium/liquidio/lio_main.c:1827:54-56: WARNING !A || A && B is equivalent to !A || B
>
>Fixes: 8979f428a4af ("net: liquidio: release resources when liquidio driver open failed")
>Reported-by: kernel test robot <lkp@...el.com>
>Signed-off-by: Leon Romanovsky <leonro@...dia.com>
>---
>The fixed patch was in net, so sending the fix to net too.
>---

I don't follow the above note, but anyway:

Reviewed-by: Saeed Mahameed <saeed@...nel.org>