netdev - Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2022 15:14:53 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Dan Carpenter <error27@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

On 16 Nov 08:55, Yoshihiro Shimoda wrote:
>Smatch detected the following warning.
>
>    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
>    '%pM' cannot be followed by 'n'
>
>The 'n' should be '\n'.
>
>Reported-by: Dan Carpenter <error27@...il.com>
>Suggested-by: Geert Uytterhoeven <geert+renesas@...der.be>
>Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")

I would drop the Fixes tag, this shoiuldn't go to net and -stable. 
and please tag either [PATCH net] or [PATCH net-next], this one should be
net-next.

Thanks,
you can add:
Reviewed-by: Saeed Mahameed <saeed@...nel.org>