[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3SPJprgA9l35k5v@DEN-LT-70577>
Date: Wed, 16 Nov 2022 07:09:12 +0000
From: <Daniel.Machon@...rochip.com>
To: <error27@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <Lars.Povlsen@...rochip.com>,
<Steen.Hegelund@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
<netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] net: microchip: sparx5: prevent uninitialized
variable
> Smatch complains that:
>
> drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c:112
> sparx5_dcb_apptrust_validate() error: uninitialized symbol 'match'.
>
> This would only happen if the:
>
> if (sparx5_dcb_apptrust_policies[i].nselectors != nselectors)
>
> condition is always true (they are not equal). The "nselectors"
> variable comes from dcbnl_ieee_set() and it is a number between 0-256.
> This seems like a probably a real bug.
That is indeed a bug.
Thank you, much appreciated.
>
> Fixes: 23f8382cd95d ("net: microchip: sparx5: add support for apptrust")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> index 8108f3767767..74abb946b2a3 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> @@ -90,7 +90,7 @@ static int sparx5_dcb_app_validate(struct net_device *dev,
> static int sparx5_dcb_apptrust_validate(struct net_device *dev, u8 *selectors,
> int nselectors, int *err)
> {
> - bool match;
> + bool match = false;
> int i, ii;
>
> for (i = 0; i < ARRAY_SIZE(sparx5_dcb_apptrust_policies); i++) {
> --
> 2.35.1
>
Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>
Powered by blists - more mailing lists