| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202211161617.nKmDXeXX-lkp@intel.com>
Date: Wed, 16 Nov 2022 17:03:16 +0800
From: kernel test robot <lkp@...el.com>
To: Stanislav Fomichev <sdf@...gle.com>, bpf@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
martin.lau@...ux.dev, song@...nel.org, yhs@...com,
john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
haoluo@...gle.com, jolsa@...nel.org,
David Ahern <dsahern@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
Willem de Bruijn <willemb@...gle.com>,
Jesper Dangaard Brouer <brouer@...hat.com>,
Anatoly Burakov <anatoly.burakov@...el.com>,
Alexander Lobakin <alexandr.lobakin@...el.com>,
Magnus Karlsson <magnus.karlsson@...il.com>,
Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 06/11] xdp: Carry over xdp metadata into skb
context
Hi Stanislav,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/xdp-hints-via-kfuncs/20221115-110547
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20221115030210.3159213-7-sdf%40google.com
patch subject: [PATCH bpf-next 06/11] xdp: Carry over xdp metadata into skb context
config: arm64-randconfig-r001-20221115
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/5c7e4e60d13af8491563dd4d2ad5fc684420e540
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Stanislav-Fomichev/xdp-hints-via-kfuncs/20221115-110547
git checkout 5c7e4e60d13af8491563dd4d2ad5fc684420e540
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash net/mac80211/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from net/mac80211/s1g.c:6:
In file included from include/linux/ieee80211.h:20:
In file included from include/linux/etherdevice.h:21:
In file included from include/linux/netdevice.h:43:
include/net/xdp.h:449:2: error: void function 'xdp_metadata_export_to_skb' should not return a value [-Wreturn-type]
return 0;
^ ~
>> net/mac80211/s1g.c:103:36: warning: implicit conversion from 'unsigned long' to '__u16' (aka 'unsigned short') changes value from 18446744073709551614 to 65534 [-Wconstant-conversion]
twt_agrt->req_type &= cpu_to_le16(~IEEE80211_TWT_REQTYPE_REQUEST);
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/byteorder/generic.h:90:21: note: expanded from macro 'cpu_to_le16'
#define cpu_to_le16 __cpu_to_le16
^
include/uapi/linux/byteorder/big_endian.h:36:53: note: expanded from macro '__cpu_to_le16'
#define __cpu_to_le16(x) ((__force __le16)__swab16((x)))
~~~~~~~~~~^~~
include/uapi/linux/swab.h:107:12: note: expanded from macro '__swab16'
__fswab16(x))
~~~~~~~~~ ^
1 warning and 1 error generated.
vim +103 net/mac80211/s1g.c
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 94
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 95 static void
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 96 ieee80211_s1g_rx_twt_setup(struct ieee80211_sub_if_data *sdata,
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 97 struct sta_info *sta, struct sk_buff *skb)
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 98 {
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 99 struct ieee80211_mgmt *mgmt = (void *)skb->data;
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 100 struct ieee80211_twt_setup *twt = (void *)mgmt->u.action.u.s1g.variable;
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 101 struct ieee80211_twt_params *twt_agrt = (void *)twt->params;
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 102
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 @103 twt_agrt->req_type &= cpu_to_le16(~IEEE80211_TWT_REQTYPE_REQUEST);
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 104
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 105 /* broadcast TWT not supported yet */
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 106 if (twt->control & IEEE80211_TWT_CONTROL_NEG_TYPE_BROADCAST) {
7ff379ba2d4b7b Johannes Berg 2021-09-27 107 twt_agrt->req_type &=
7ff379ba2d4b7b Johannes Berg 2021-09-27 108 ~cpu_to_le16(IEEE80211_TWT_REQTYPE_SETUP_CMD);
7ff379ba2d4b7b Johannes Berg 2021-09-27 109 twt_agrt->req_type |=
7ff379ba2d4b7b Johannes Berg 2021-09-27 110 le16_encode_bits(TWT_SETUP_CMD_REJECT,
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 111 IEEE80211_TWT_REQTYPE_SETUP_CMD);
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 112 goto out;
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 113 }
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 114
30ac96f7cc973b Howard Hsu 2022-10-27 115 /* TWT Information not supported yet */
30ac96f7cc973b Howard Hsu 2022-10-27 116 twt->control |= IEEE80211_TWT_CONTROL_RX_DISABLED;
30ac96f7cc973b Howard Hsu 2022-10-27 117
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 118 drv_add_twt_setup(sdata->local, sdata, &sta->sta, twt);
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 119 out:
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 120 ieee80211_s1g_send_twt_setup(sdata, mgmt->sa, sdata->vif.addr, twt);
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 121 }
f5a4c24e689f54 Lorenzo Bianconi 2021-08-23 122
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (198705 bytes)
Powered by blists - more mailing lists