netdev - Re: [PATCH net v2] net/mlx4: Check retval of mlx4_bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3YPV4csGxEJ6uSl@unreal>
Date:   Thu, 17 Nov 2022 12:39:19 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Peter Kosyh <pkosyh@...dex.ru>
Cc:     Tariq Toukan <tariqt@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH net v2] net/mlx4: Check retval of mlx4_bitmap_init

On Wed, Nov 16, 2022 at 01:08:06PM +0300, Peter Kosyh wrote:
> If mlx4_bitmap_init fails, mlx4_bitmap_alloc_range will dereference
> the NULL pointer (bitmap->table).
> 
> Make sure, that mlx4_bitmap_alloc_range called in no error case.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: d57febe1a478 ("net/mlx4: Add A0 hybrid steering")
> 
> Signed-off-by: Peter Kosyh <pkosyh@...dex.ru>
> 
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Please don't add blank lines between tags and your Signed-off-by should
be last.

Thanks