netdev - Re: [PATCH net-next] net: microchip: sparx5: prevent uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3ZTWIas5BSxwyg8@kadam>
Date:   Thu, 17 Nov 2022 18:29:28 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Machon <daniel.machon@...rochip.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: microchip: sparx5: prevent uninitialized
 variable

On Thu, Nov 17, 2022 at 04:03:07PM +0100, Paolo Abeni wrote:
> Hello,
> 
> On Tue, 2022-11-15 at 16:14 +0300, Dan Carpenter wrote:
> > Smatch complains that:
> > 
> >     drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c:112
> >     sparx5_dcb_apptrust_validate() error: uninitialized symbol 'match'.
> > 
> > This would only happen if the:
> > 
> > 	if (sparx5_dcb_apptrust_policies[i].nselectors != nselectors)
> > 
> > condition is always true (they are not equal).  The "nselectors"
> > variable comes from dcbnl_ieee_set() and it is a number between 0-256.
> > This seems like a probably a real bug.
> > 
> > Fixes: 23f8382cd95d ("net: microchip: sparx5: add support for apptrust")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> checkpatch complains about the From/SoB mismatch - 
> 'Dan Carpenter <error27@...il.com>' vs 'Dan Carpenter
> <dan.carpenter@...cle.com>'
> 
> Could you please send a v2 addressing that?

Oops.  Sorry.  Resent.

regards,
dan carpenter