netdev - Re: [PATCH net 5/5] hsr: Synchronize sequence number updates.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211180050.9lHjRi5N-lkp@intel.com>
Date:   Fri, 18 Nov 2022 00:47:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        netdev@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Juhee Kang <claudiajkang@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH net 5/5] hsr: Synchronize sequence number updates.

Hi Sebastian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/hsr-HSR-send-recv-fixes/20221117-010114
patch link:    https://lore.kernel.org/r/20221116165943.1776754-6-bigeasy%40linutronix.de
patch subject: [PATCH net 5/5] hsr: Synchronize sequence number updates.
config: riscv-randconfig-r003-20221117
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/d50e5c90d21a4d0291280f2c7dc5287d2597bf56
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sebastian-Andrzej-Siewior/hsr-HSR-send-recv-fixes/20221117-010114
        git checkout d50e5c90d21a4d0291280f2c7dc5287d2597bf56
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/hsr/hsr_framereg.c:465:6: error: call to '__compiletime_assert_370' declared with 'error' attribute: BUILD_BUG failed
           if (cmpxchg(&node->seq_out[port->type], old_seq, sequence_nr) != old_seq)
               ^
   include/linux/atomic/atomic-instrumented.h:1916:2: note: expanded from macro 'cmpxchg'
           arch_cmpxchg(__ai_ptr, __VA_ARGS__); \
           ^
   arch/riscv/include/asm/cmpxchg.h:344:23: note: expanded from macro 'arch_cmpxchg'
           (__typeof__(*(ptr))) __cmpxchg((ptr),                           \
                                ^
   arch/riscv/include/asm/cmpxchg.h:335:3: note: expanded from macro '__cmpxchg'
                   BUILD_BUG();                                            \
                   ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/compiler_types.h:345:2: note: expanded from macro '_compiletime_assert'
           __compiletime_assert(condition, msg, prefix, suffix)
           ^
   include/linux/compiler_types.h:338:4: note: expanded from macro '__compiletime_assert'
                           prefix ## suffix();                             \
                           ^
   <scratch space>:3:1: note: expanded from here
   __compiletime_assert_370
   ^
   1 error generated.


vim +465 net/hsr/hsr_framereg.c

   444	
   445	/* 'skb' is a HSR Ethernet frame (with a HSR tag inserted), with a valid
   446	 * ethhdr->h_source address and skb->mac_header set.
   447	 *
   448	 * Return:
   449	 *	 1 if frame can be shown to have been sent recently on this interface,
   450	 *	 0 otherwise, or
   451	 *	 negative error code on error
   452	 */
   453	int hsr_register_frame_out(struct hsr_port *port, struct hsr_node *node,
   454				   u16 sequence_nr)
   455	{
   456		u16 old_seq;
   457	again:
   458		old_seq = READ_ONCE(node->seq_out[port->type]);
   459	
   460		if (seq_nr_before_or_eq(sequence_nr, old_seq) &&
   461		    time_is_after_jiffies(node->time_out[port->type] +
   462		    msecs_to_jiffies(HSR_ENTRY_FORGET_TIME)))
   463			return 1;
   464	
 > 465		if (cmpxchg(&node->seq_out[port->type], old_seq, sequence_nr) != old_seq)
   466			goto again;
   467	
   468		node->time_out[port->type] = jiffies;
   469		return 0;
   470	}
   471	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (141125 bytes)