netdev - Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3W0SwFS9uDtzHm3@kadam>
Date:   Thu, 17 Nov 2022 07:10:51 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

On Thu, Nov 17, 2022 at 06:58:19AM +0300, Dan Carpenter wrote:
> On Wed, Nov 16, 2022 at 03:14:53PM -0800, Saeed Mahameed wrote:
> > On 16 Nov 08:55, Yoshihiro Shimoda wrote:
> > > Smatch detected the following warning.
> > > 
> > >    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > >    '%pM' cannot be followed by 'n'
> > > 
> > > The 'n' should be '\n'.
> > > 
> > > Reported-by: Dan Carpenter <error27@...il.com>
> > > Suggested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > 
> > I would drop the Fixes tag, this shoiuldn't go to net and -stable.
> 
> Some maintainers would want a Fixes tag for this and some wouldn't...

Immediately after I sent this email a different maintainer asked me to
add a Fixes tag to a patch removing an unnecessary NULL check to silence
checker warning about inconsistent NULL checking.

Generally I would have put a Fixes tag here because the typo gets to the
users but I wouldn't put a Fixes tag for typos in the comments.

regards,
dan carpenter