netdev - Re: [PATCH net-next] sandlan: Add the sandlan virtual network interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211171343.5rZV8E6U-lkp@intel.com>
Date:   Thu, 17 Nov 2022 13:35:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Steve Williams <steve.williams@...cruise.com>,
        netdev@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Stephen Williams <steve.williams@...cruise.com>
Subject: Re: [PATCH net-next] sandlan: Add the sandlan virtual network
 interface

Hi Steve,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Steve-Williams/sandlan-Add-the-sandlan-virtual-network-interface/20221117-064142
patch link:    https://lore.kernel.org/r/20221116222429.7466-1-steve.williams%40getcruise.com
patch subject: [PATCH net-next] sandlan: Add the sandlan virtual network interface
config: sparc-allyesconfig
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/56bfd7226aeb87ad32bde47f6b055e06ea9d0090
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Steve-Williams/sandlan-Add-the-sandlan-virtual-network-interface/20221117-064142
        git checkout 56bfd7226aeb87ad32bde47f6b055e06ea9d0090
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In function 'do_init_domain',
       inlined from 'sandlan_dom_alloc' at drivers/net/sandlan/sandlan_domain.c:106:2:
>> drivers/net/sandlan/sandlan_domain.c:91:9: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
      91 |         strncpy(domain->name, name, sizeof(domain->name));
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/strncpy +91 drivers/net/sandlan/sandlan_domain.c

    87	
    88	static void do_init_domain(struct sandlan_domain *domain, const char *name)
    89	{
    90		INIT_LIST_HEAD(&domain->domains_list);
  > 91		strncpy(domain->name, name, sizeof(domain->name));
    92		INIT_LIST_HEAD(&domain->nodes_list);
    93	}
    94	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322296 bytes)