netdev - RE: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 08:57:26 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Saeed Mahameed <saeed@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Dan Carpenter <error27@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: RE: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

Hi Vladimir,

> From: Vladimir Oltean, Sent: Thursday, November 17, 2022 8:36 AM
> 
> On Wed, Nov 16, 2022 at 03:14:53PM -0800, Saeed Mahameed wrote:
> > On 16 Nov 08:55, Yoshihiro Shimoda wrote:
> > > Smatch detected the following warning.
> > >
> > >    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > >    '%pM' cannot be followed by 'n'
> > >
> > > The 'n' should be '\n'.
> > >
> > > Reported-by: Dan Carpenter <error27@...il.com>
> > > Suggested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> >
> > I would drop the Fixes tag, this shoiuldn't go to net and -stable. and
> > please tag either [PATCH net] or [PATCH net-next], this one should be
> > net-next.
> >
> > Thanks,
> > you can add:
> > Reviewed-by: Saeed Mahameed <saeed@...nel.org>
> 
> You can have a Fixes: tag on a patch sent to net-next no problem.
> No need to drop it.

I got it.

> But in the future, using git-format-patch
> --subject-prefix="PATCH net" (or net-next) would be indeed advisable.

I'll send v2 patch by using --subject-prefix="PATCH v2 net-next".

Best regards,
Yoshihiro Shimoda