netdev - Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3X7gWCP3h6OQb47@unreal>
Date:   Thu, 17 Nov 2022 11:14:41 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Dan Carpenter <error27@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

On Thu, Nov 17, 2022 at 09:59:55AM +0100, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
> 
> On Thu, Nov 17, 2022 at 9:58 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@...esas.com> wrote:
> > > From: Leon Romanovsky, Sent: Thursday, November 17, 2022 3:09 PM
> > > On Wed, Nov 16, 2022 at 08:55:19AM +0900, Yoshihiro Shimoda wrote:
> > > > Smatch detected the following warning.
> > > >
> > > >     drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > > >     '%pM' cannot be followed by 'n'
> > > >
> > > > The 'n' should be '\n'.
> > > >
> > > > Reported-by: Dan Carpenter <error27@...il.com>
> > > > Suggested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > > > ---
> > > >  drivers/net/ethernet/renesas/rswitch.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> > > > index f3d27aef1286..51ce5c26631b 100644
> > > > --- a/drivers/net/ethernet/renesas/rswitch.c
> > > > +++ b/drivers/net/ethernet/renesas/rswitch.c
> > > > @@ -1714,7 +1714,7 @@ static int rswitch_init(struct rswitch_private *priv)
> > > >     }
> > > >
> > > >     for (i = 0; i < RSWITCH_NUM_PORTS; i++)
> > > > -           netdev_info(priv->rdev[i]->ndev, "MAC address %pMn",
> > > > +           netdev_info(priv->rdev[i]->ndev, "MAC address %pM\n",
> > >
> > > You can safely drop '\n' from here. It is not needed while printing one
> > > line.
> >
> > Oh, I didn't know that. I'll remove '\n' from here on v2 patch.
> 
> Please don't remove it.  The convention is to have the newlines.

Can you please explain why?

Thanks

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds