netdev - Re: [PATCH 2/2] net: stmmac: tegra: Add MGBE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <662fd424-7f9a-eba1-a223-902e8e463021@nvidia.com>
Date:   Fri, 18 Nov 2022 09:28:38 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Revanth Kumar Uppala <ruppala@...dia.com>, f.fainelli@...il.com
Cc:     andrew@...n.ch, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, linux-tegra@...r.kernel.org,
        linux@...linux.org.uk, netdev@...r.kernel.org, olteanv@...il.com,
        pabeni@...hat.com, thierry.reding@...il.com, vbhadram@...dia.com,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH 2/2] net: stmmac: tegra: Add MGBE support


On 18/11/2022 07:57, Revanth Kumar Uppala wrote:
> From: Bhadram Varka <vbhadram@...dia.com>
> 
> Add support for the Multi-Gigabit Ethernet (MGBE/XPCS) IP found on
> NVIDIA Tegra234 SoCs.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> Signed-off-by: Bhadram Varka <vbhadram@...dia.com>
> Co-developed-by: Revanth Kumar Uppala <ruppala@...dia.com>
> Signed-off-by: Revanth Kumar Uppala <ruppala@...dia.com>
> ---

This should have been marked as 'V5'. If we need to resend please let us 
know. We are also missing what has been changed since the last version. 
I know that in this version the following changes were made:

1. Reduce time spent polling for the RX link to be ready
2. Propagate the errors when bringing up the link fails.
3. Added suspend/resume support
4. Ensure clocks are disabled again on probe/resume failure

Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>

Thanks
Jon

-- 
nvpublic