netdev - RE: [PATCH net-next 00/13] resource management using devlink reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB002998FAA385731E21E20868E9099@MWHPR11MB0029.namprd11.prod.outlook.com>
Date:   Fri, 18 Nov 2022 14:23:50 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Leon Romanovsky <leon@...nel.org>, Jakub Kicinski <kuba@...nel.org>
CC:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "jiri@...dia.com" <jiri@...dia.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "Drewek, Wojciech" <wojciech.drewek@...el.com>,
        "Czapnik, Lukasz" <lukasz.czapnik@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
        "Raczynski, Piotr" <piotr.raczynski@...el.com>,
        "Keller, Jacob E" <jacob.e.keller@...el.com>,
        "Ertman, David M" <david.m.ertman@...el.com>,
        "Kaliszczuk, Leszek" <leszek.kaliszczuk@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: RE: [PATCH net-next 00/13] resource management using devlink reload

> Subject: Re: [PATCH net-next 00/13] resource management using devlink reload
> 
> On Thu, Nov 17, 2022 at 07:36:18PM -0800, Jakub Kicinski wrote:
> > On Thu, 17 Nov 2022 19:38:48 +0200 Leon Romanovsky wrote:
> > > I don't think that management of PCI specific parameters in devlink
> > > is right idea. PCI has his own subsystem with rules and assumptions,
> > > netdev shouldn't mangle them.
> >
> > Not netdev, devlink, which covers netdev, RDMA and others.
> 
> devlink is located in net/*, it is netdev.
> Regarding RDMA, it is not fully accurate. We use devlink to convey information to
> FW through pci device located in netdev. Some of such parameters are RDMA
> related. However, we don't configure RDMA properties through devlink, there is a
> special tool for that (rdmatool).

rdmatool though is usable only once the rdma driver probe() completes and the ib_device is registered.
And cannot be used for any configurations at driver init time.

Don't we already have PCI specific parameters managed through devlink today?

https://docs.kernel.org/networking/devlink/devlink-params.html
enable_sriov
ignore_ari
msix_vec_per_pf_max
msix_vec_per_pf_min

How are these in a different bracket from what Michal is trying to do? Or were these ones a bad idea in hindsight?

Shiraz