netdev - Re: [PATCH net 2/3] nfc: st-nci: fix memory leaks in EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 14:14:08 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Martin Faltesek <mfaltesek@...gle.com>
Cc:     kuba@...nel.org, netdev@...r.kernel.org, linux-nfc@...ts.01.org,
        krzysztof.kozlowski@...aro.org, davem@...emloft.net,
        martin.faltesek@...il.com, christophe.ricard@...il.com,
        jordy@...ing.systems, krzk@...nel.org, sameo@...ux.intel.com,
        theflamefire89@...il.com, duoming@....edu.cn,
        Denis Efremov <denis.e.efremov@...cle.com>
Subject: Re: [PATCH net 2/3] nfc: st-nci: fix memory leaks in EVT_TRANSACTION

On Fri, Nov 18, 2022 at 2:04 PM Martin Faltesek <mfaltesek@...gle.com> wrote:
>
> Error path does not free previously allocated memory. Add devm_kfree() to
> the failure path.
>
> Reported-by: Denis Efremov <denis.e.efremov@...cle.com>
> Fixes: 5d1ceb7f5e56 ("NFC: st21nfcb: Add HCI transaction event support")
> Signed-off-by: Martin Faltesek <mfaltesek@...gle.com>

Reviewed-by: Guenter Roeck <groeck@...gle.com>

> ---
>  drivers/nfc/st-nci/se.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
> index 589e1dec78e7..fc59916ae5ae 100644
> --- a/drivers/nfc/st-nci/se.c
> +++ b/drivers/nfc/st-nci/se.c
> @@ -339,8 +339,10 @@ static int st_nci_hci_connectivity_event_received(struct nci_dev *ndev,
>
>                 /* Check next byte is PARAMETERS tag (82) */
>                 if (skb->data[transaction->aid_len + 2] !=
> -                   NFC_EVT_TRANSACTION_PARAMS_TAG)
> +                   NFC_EVT_TRANSACTION_PARAMS_TAG) {
> +                       devm_kfree(dev, transaction);
>                         return -EPROTO;
> +               }
>
>                 transaction->params_len = skb->data[transaction->aid_len + 3];
>                 memcpy(transaction->params, skb->data +
> --
> 2.38.1.584.g0f3c55d4c2-goog
>