netdev - Re: [PATCHv4 net] bonding: fix ICMPv6 header handling when receiving IPv6 messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKK_Y6q5yE_z9tXzNk8GNHVQZ_5zRtwK_pNRDYC5+p14Q@mail.gmail.com>
Date:   Thu, 17 Nov 2022 19:56:39 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Tom Herbert <tom@...bertland.com>, Liang Li <liali@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCHv4 net] bonding: fix ICMPv6 header handling when receiving
 IPv6 messages

On Thu, Nov 17, 2022 at 7:44 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> Currently, we get icmp6hdr via function icmp6_hdr(), which needs the skb
> transport header to be set first. But there is no rule to ask driver set
> transport header before netif_receive_skb() and bond_handle_frame(). So
> we will not able to get correct icmp6hdr on some drivers.
>
> Fix this by using skb_header_pointer to get the IPv6 and ICMPV6 headers.
>
> Reported-by: Liang Li <liali@...hat.com>
> Fixes: 4e24be018eb9 ("bonding: add new parameter ns_targets")
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>