netdev - Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix memory leak in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221117211315.1402a27c@kernel.org>
Date:   Thu, 17 Nov 2022 21:13:15 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yan Cangang <nalanzeyu@...il.com>
Cc:     leon@...nel.org, Mark-MC.Lee@...iatek.com, john@...ozen.org,
        nbd@....name, netdev@...r.kernel.org, sean.wang@...iatek.com
Subject: Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix memory leak in error
 path

On Wed, 16 Nov 2022 13:14:07 +0800 Yan Cangang wrote:
> In mtk_ppe_init(), when dmam_alloc_coherent() or devm_kzalloc() failed,
> the rhashtable ppe->l2_flows isn't destroyed. Fix it.
> 
> In mtk_probe(), when mtk_eth_offload_init() or register_netdev() failed,
> have the same problem. Also, call to mtk_mdio_cleanup() is missed in this
> case. Fix it.
> 
> Fixes: 33fc42de3327 ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries")
> Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Signed-off-by: Yan Cangang <nalanzeyu@...il.com>

Please break this fix up into a series of two patches, first one fixing
the issue in ba37b7caf1ed and 502e84e2382d, and second one fixing the
issue in 33fc42de3327. Those are separate fixes, and should be
backported differently (the former is needed in LTS).

Please repost with the subject changed as Leon suggested and do not
repost in this thread, start a new thread.