netdev - Re: [PATCH net] wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <215ec3cc-88ad-3f68-6dc3-c1aed2a17c76@huawei.com>
Date:   Sat, 19 Nov 2022 17:20:21 +0800
From:   "Ziyang Xuan (William)" <william.xuanziyang@...wei.com>
To:     Kalle Valo <kvalo@...nel.org>
CC:     <srini.raju@...elifi.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] wifi: plfxlc: fix potential memory leak in
 __lf_x_usb_enable_rx()

> Ziyang Xuan <william.xuanziyang@...wei.com> writes:
> 
>> urbs does not be freed in exception paths in __lf_x_usb_enable_rx().
>> That will trigger memory leak. To fix it, add kfree() for urbs within
>> "error" label. Compile tested only.
>>
>> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices")
>> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>
>> ---
>>  drivers/net/wireless/purelifi/plfxlc/usb.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> plfxlc patches go to wireless tree, not net. But I think I'll take this
> to wireless-next actually.

OK, thanks.

>