netdev - RE: [PATCH net-next v3] ethtool: add netlink based get rss support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Nov 2022 08:40:19 +0000
From:   "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
To:     Francois Romieu <romieu@...zoreil.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "corbet@....net" <corbet@....net>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [PATCH net-next v3] ethtool: add netlink based get rss support



> -----Original Message-----
> From: Francois Romieu <romieu@...zoreil.com>
> Subject: Re: [PATCH net-next v3] ethtool: add netlink based get rss
> support
> 
> Sudheer Mogilappagari <sudheer.mogilappagari@...el.com> :
> > Add netlink based support for "ethtool -x <dev> [context x]"
> > command by implementing ETHTOOL_MSG_RSS_GET netlink message.
> > This is equivalent to functionality provided via ETHTOOL_GRSSH
>                                                    ^^^^^^^^^^^^^
> Nit: s/ETHTOOL_GRSSH/ETHTOOL_GRXFH/
> 

Hi Ueimor, 
My observation is there is mix-up of names in current ioctl implementation where ethtool_get_rxfh() is called for ETHTOOL_GRSSH command. Since this implementation is for ETHTOOL_GRSSH ioctl, we are using RSS instead of RXFH as Jakub suggested earlier. Why do you think it should be ETHOOL_GRXFH ?

https://elixir.bootlin.com/linux/latest/source/net/ethtool/ioctl.c#L2916

	case ETHTOOL_GRXFH:
		rc = ethtool_get_rxnfc(dev, ethcmd, useraddr);

	case ETHTOOL_GRSSH:
		rc = ethtool_get_rxfh(dev, useraddr);

-Sudheer