lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Nov 2022 00:35:19 +0100 From: Andrew Lunn <andrew@...n.ch> To: Tim Harvey <tharvey@...eworks.com> Cc: Ansuel Smith <ansuelsmth@...il.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org> Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes On Fri, Nov 18, 2022 at 11:57:00AM -0800, Tim Harvey wrote: > On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn <andrew@...n.ch> wrote: > > > > > Andrew, > > > > > > I completely agree with you but I haven't seen how that can be done > > > yet. What support exists for a PHY driver to expose their LED > > > configuration to be used that way? Can you point me to an example? > > > > Nobody has actually worked on this long enough to get code merged. e.g. > > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > > https://lists.archive.carbon60.com/linux/kernel/3396223 > > > > This is probably the last attempt, which was not too far away from getting merged: > > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > > > I seem to NACK a patch like yours every couple of months. If all that > > wasted time was actually spent on a common framework, this would of > > been solved years ago. > > > > How important is it to you to control these LEDs? Enough to finish > > this code and get it merged? > > > > Andrew, > > Thanks for the links - the most recent attempt does look promising. > For whatever reason I don't have that series in my mail history so > it's not clear how I can respond to it. apt-get install b4 > Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs > with offload triggers' [1]? > > I'm not all that familiar with netdev led triggers. Is there a way to > configure the default offload blink mode via dt with your series? I > didn't quite follow how the offload function/blink-mode gets set. The idea is that the PHY LEDs are just LEDs in the Linux LED framework. So read Documentation/devicetree/bindings/leds/common.yaml. The PHY should make use of these standard DT properties, including linux,default-trigger. Andrew
Powered by blists - more mailing lists