lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <16d361992b707848c0b0258ad1d0e4c3958155e7.camel@xry111.site>
Date:   Mon, 21 Nov 2022 21:03:14 +0800
From:   Xi Ruoyao <xry111@...111.site>
To:     Feiyang Chen <chris.chenfeiyang@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, Feiyang Chen <chenfeiyang@...ngson.cn>,
        zhangqing@...ngson.cn, Huacai Chen <chenhuacai@...ngson.cn>,
        netdev@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH] stmmac: pci: Add LS7A support for dwmac-loongson

On Thu, 2022-08-18 at 13:01 +0800, Feiyang Chen wrote:
> On Thu, 18 Aug 2022 at 10:19, Andrew Lunn <andrew@...n.ch> wrote:
> > 
> > On Tue, Aug 16, 2022 at 06:25:37PM +0800, Feiyang Chen wrote:
> > > Current dwmac-loongson only support LS2K in the "probed with PCI
> > > and
> > > configured with DT" manner. We add LS7A support on which the
> > > devices
> > > are fully PCI (non-DT).
> > 
> > Please could you break this patch up into a number of smaller
> > patches. It is very hard to follow what you are changing here.
> > 
> > Ideally you want lots of small patches, each with a good commit
> > message, which are obviously correct.
> > 
> 
> Hi, Andrew,
> 
> OK, I will have a try.

Any progress on the refactoring? :)

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ