netdev - Re: [RFC PATCH v4 2/3] io_uring: add api to set / get napi configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529345e2-5e13-0549-0f6b-be8fe091b8ff@kernel.dk>
Date:   Mon, 21 Nov 2022 10:35:20 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Stefan Roesch <shr@...kernel.io>, kernel-team@...com
Cc:     olivier@...llion01.com, netdev@...r.kernel.org,
        io-uring@...r.kernel.org, kuba@...nel.org
Subject: Re: [RFC PATCH v4 2/3] io_uring: add api to set / get napi
 configuration.

On 11/21/22 10:29 AM, Stefan Roesch wrote:
> This adds an api to register the busy poll timeout from liburing. To be
> able to use this functionality, the corresponding liburing patch is needed.
> 
> Signed-off-by: Stefan Roesch <shr@...kernel.io>
> ---
>  include/linux/io_uring_types.h |  2 +-
>  include/uapi/linux/io_uring.h  | 11 +++++++
>  io_uring/io_uring.c            | 54 ++++++++++++++++++++++++++++++++++
>  3 files changed, 66 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/io_uring_types.h b/include/linux/io_uring_types.h
> index 23993b5d3186..67b861305d97 100644
> --- a/include/linux/io_uring_types.h
> +++ b/include/linux/io_uring_types.h
> @@ -274,8 +274,8 @@ struct io_ring_ctx {
>  	struct list_head	napi_list;	/* track busy poll napi_id */
>  	spinlock_t		napi_lock;	/* napi_list lock */
>  
> -	unsigned int		napi_busy_poll_to; /* napi busy poll default timeout */
>  	bool			napi_prefer_busy_poll;
> +	unsigned int		napi_busy_poll_to;
>  #endif

Why is this being moved? Seems unrelated, and it actually creates another
hole rather than filling one as it did before.

-- 
Jens Axboe