netdev - Re: [PATCH] ethtool: avoiding integer overflow in ethtool_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121121258.4f359da8@kernel.org>
Date:   Mon, 21 Nov 2022 12:12:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Guangbin Huang <huangguangbin2@...wei.com>,
        Andrew Lunn <andrew@...n.ch>, Tom Rix <trix@...hat.com>,
        Marco Bonelli <marco@...eim.net>,
        Edward Cree <ecree@...arflare.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] ethtool: avoiding integer overflow in ethtool_phys_id()

On Mon, 21 Nov 2022 10:56:18 +0300 Maxim Korotkov wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 2adc6edcaec0 ("ethtool: fix error handling in ethtool_phys_id")

I'm leaning towards dropping the fixes tag, and applying to -next.
Drivers returning high enough rc to cause an overflow seems theoretical, 
and is pretty harmless. Please LMK if I'm missing something.