netdev - Re: [PATCH net-next 11/17] net: dsa: move dsa_tree_notify() and dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <397d903f-719d-f85f-708a-5a0b717a1ff4@gmail.com>
Date:   Mon, 21 Nov 2022 12:34:34 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 11/17] net: dsa: move dsa_tree_notify() and
 dsa_broadcast() to switch.c

On 11/21/22 05:55, Vladimir Oltean wrote:
> There isn't an intuitive place for these 2 cross-chip notifier functions
> according to the function-to-file classification based on names
> (dsa_switch_*() goes to switch.c), but I consider these to be part of
> the cross-chip notifier handling, therefore part of switch.c. Move them
> there to reduce bloat in dsa2.c (the place where all code with no better
> place to go goes).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian